xintongsong commented on a change in pull request #10146:
[FLINK-14188][runtime] TaskExecutor derive and register with default slot
resource profile
URL: https://github.com/apache/flink/pull/10146#discussion_r350097727
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
##########
@@ -136,6 +138,20 @@
" is typically proportional to the number of
physical CPU cores that the TaskManager's machine has" +
" (e.g., equal to the number of cores, or half
the number of cores).");
+ /**
+ * Fraction of TaskExecutor resources a default slot should take for
slot requests with unknown resource profiles.
+ */
+ @Documentation.CommonOption(position =
Documentation.CommonOption.POSITION_PARALLELISM_SLOTS)
+ public static final ConfigOption<Float> DEFAULT_SLOT_FRACTION =
+ key("taskmanager.default-slot-fraction")
+ .defaultValue(-1.0f)
Review comment:
I'm in favor of using negative values to represent the config option is not
configured. This makes it possible for the users to explicitly unset the option
by overwriting it to a negative value.
I think we do not need to worry about removing `NUM_TASK_SLOTS` at the
moment. I don't think we should remove it, at least in short time, for
backwards compatibility.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
