xintongsong commented on a change in pull request #10146:
[FLINK-14188][runtime] TaskExecutor derive and register with default slot
resource profile
URL: https://github.com/apache/flink/pull/10146#discussion_r352400431
##########
File path:
flink-mesos/src/main/java/org/apache/flink/mesos/util/MesosUtils.java
##########
@@ -107,8 +107,6 @@ public static MesosTaskManagerParameters
createTmParameters(Configuration config
final MesosTaskManagerParameters taskManagerParameters =
MesosTaskManagerParameters.create(configuration);
final TaskExecutorResourceSpec taskExecutorResourceSpec =
taskManagerParameters.containeredParameters().getTaskExecutorResourceSpec();
- log.info("TaskManagers will be created with {} task slots",
-
taskManagerParameters.containeredParameters().numSlots());
Review comment:
This commit already remove `numSlots()`, but not yet adding
`TaskExecutorResourceSpec#getDefaultSlotFraction` and
`TaskExecutorResourceUtils#generateDefaultSlotResourceProfile`
We probably should move this commit to after '[FLINK-14188][runtime] Derive
TaskExecutor default slot resource profile from configuration.' ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
