xintongsong commented on a change in pull request #10146:
[FLINK-14188][runtime] TaskExecutor derive and register with default slot
resource profile
URL: https://github.com/apache/flink/pull/10146#discussion_r352403042
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/ContaineredTaskManagerParameters.java
##########
@@ -69,8 +60,7 @@ public int numSlots() {
@Override
public String toString() {
return "TaskManagerParameters {" +
- "taskExecutorResourceSpec=" + (taskExecutorResourceSpec
== null ? "null" : taskExecutorResourceSpec) +
Review comment:
Actually, #10161 does not include this change. But you're right, this change
should belongs to #10161.
I'll update #10161 to include this change, so we can remove it from this PR
when we do rebasing later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services