azagrebin commented on a change in pull request #10146: [FLINK-14188][runtime]
TaskExecutor derive and register with default slot resource profile
URL: https://github.com/apache/flink/pull/10146#discussion_r351874199
##########
File path:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java
##########
@@ -403,7 +395,7 @@ public static MesosTaskManagerParameters
create(Configuration flinkConfig) {
Option<String> tmBootstrapCommand =
Option.apply(flinkConfig.getString(MESOS_TM_BOOTSTRAP_CMD));
return new MesosTaskManagerParameters(
- cpus,
+
taskExecutorResourceSpec.getCpuCores().get().getValue().doubleValue(),
Review comment:
if we already have `taskExecutorResourceSpec` in `containeredParameters` we
could query cpus from there in `MesosTaskManagerParameters`. Then
`createTaskExecutorResourceSpec` can be `create
ContaineredTaskManagerParameters `.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
