[
https://issues.apache.org/jira/browse/FLINK-15179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993444#comment-16993444
]
Yang Wang commented on FLINK-15179:
-----------------------------------
[~kkl0u] Thanks a lot for your clarification. It makes sense to me to remove
the `FlinkKubernetesCustomCli` since the `AbstractCustomCommandLine` and
`FlinkYarnSessionCli` will be deprecated in the future. It is better to remove
it before some users starting to use it. I still have a concern that the help
message will not show up. It will not be so easy for beginners. Currently, we
could get the following help message. It includes some very basic config
options. I think many users may need to change it when starting a flink cluster.
{code:java}
./bin/kubernetes-session.sh -h
Usage:
Optional
-d,--detached If present, runs the job in detached mode
-D <property=value> use value for given property
-h,--help Help for Kubernetes session CLI.
-i,--image <image-name> Image to use for Flink containers
-id,--clusterId <arg> The cluster id used for identifying the
unique flink cluster. If it's not set, the client will generate a random UUID
name.
-jm,--jobManagerMemory <arg> Memory for JobManager Container with
optional unit (default: MB)
-s,--slots <arg> Number of slots per TaskManager
-tm,--taskManagerMemory <arg> Memory per TaskManager Container with
optional unit (default: MB)
{code}
Another concern is whether we need to deprecate all the cli options. I think
the cli options is public api. For `FlinkYarnSessionCli`, it will not be so
easy to remove them. I think maybe we should reach an agreement first that all
the cli options will be deprecated.
[~trohrmann], What do you think of this?
> Kubernetes should not have a CustomCommandLine.
> -----------------------------------------------
>
> Key: FLINK-15179
> URL: https://issues.apache.org/jira/browse/FLINK-15179
> Project: Flink
> Issue Type: Sub-task
> Components: Deployment / Kubernetes
> Affects Versions: 1.10.0
> Reporter: Kostas Kloudas
> Assignee: Kostas Kloudas
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> As part of FLIP-73, all command line options are mapped to config options.
> Given this 1-to-1 mapping, the Kubernetes command line could simply forward
> the command line arguments to ConfigOptions directly, instead of introducing
> new command line options. In this case, the user is expected to simply write:
>
> {\{bin/run -e (or --executor) kubernetes-session-cluster -D
> kubernetes.container.image=MY_IMAGE ...}}
> and the CLI will parse the -e to figure out the correct
> {{ClusterClientFactory}} and {{ExecutorFactory}} and then forward to that the
> config options specified with {{-D}}.
> For this, we need to introduce a {{GenericCustomCommandLine}} that simply
> forward the specified parameters to the executors.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
