[
https://issues.apache.org/jira/browse/FLINK-15179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16994744#comment-16994744
]
Till Rohrmann commented on FLINK-15179:
---------------------------------------
Thanks for the fruitful discussion [~kkl0u] and [~fly_in_gis]. I think it is
very important to align on the long term design of Flink's CLIs. If the long
term idea is to get rid of cli options and instead to use config options which
are specified via "dynamic" properties or in the future via env variable, then
I agree with Klou that we should not offer extra cli options for
{{kubernetes-session.sh}}.
How to deal with {{FlinkYarnSessionCli}} and how to transform it into the
desired state is something we could exclude from the scope of this JIRA issue
as it does not strictly affect {{kubernetes-session.sh}}. Instead we should
create a dedicated JIRA issue where we could continue the discussion. That
would also be the place to discuss the "Yarn properties file" magic (I would be
in favour of removing it). If the executors don't provide support for a help
message yet, then we should also create a separate issue to add it (ideally for
Flink 1.10).
> Kubernetes should not have a CustomCommandLine.
> -----------------------------------------------
>
> Key: FLINK-15179
> URL: https://issues.apache.org/jira/browse/FLINK-15179
> Project: Flink
> Issue Type: Sub-task
> Components: Deployment / Kubernetes
> Affects Versions: 1.10.0
> Reporter: Kostas Kloudas
> Assignee: Kostas Kloudas
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> As part of FLIP-73, all command line options are mapped to config options.
> Given this 1-to-1 mapping, the Kubernetes command line could simply forward
> the command line arguments to ConfigOptions directly, instead of introducing
> new command line options. In this case, the user is expected to simply write:
>
> {\{bin/run -e (or --executor) kubernetes-session-cluster -D
> kubernetes.container.image=MY_IMAGE ...}}
> and the CLI will parse the -e to figure out the correct
> {{ClusterClientFactory}} and {{ExecutorFactory}} and then forward to that the
> config options specified with {{-D}}.
> For this, we need to introduce a {{GenericCustomCommandLine}} that simply
> forward the specified parameters to the executors.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
