[
https://issues.apache.org/jira/browse/FLINK-15179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993241#comment-16993241
]
Yang Wang commented on FLINK-15179:
-----------------------------------
Hi, [~kkl0u] Does `AbstractCustomCommandLine` will be deprecated in the future?
If yes, the changes makes sense to me. How will we deal with the
`FlinkYarnSessionCli`. Is it a special case?
If not, adding some cli options in `FlinkKubernetesCustomCli` will make users
submitting a flink job easier.
{code:java}
./bin/kubernetes-session.sh -d -id flink-native-k8s-session-1 \
-i flink:flink-1.10-SNAPSHOT-k8s \
-jm 4096 -tm 4096 -s 4
{code}
If we remove the `FlinkKubernetesCustomCli`, the command will like the
following.
{code:java}
./bin/kubernetes-session.sh -d
-Dkubernetes.cluster-id=flink-native-k8s-session-1 \
-Dkubernetes.container.image=flink:flink-1.10-SNAPSHOT-k8s \
-Djobmanager.heap.size=4096 -Dtaskmanager.memory.total-process.size=4096 \
-Dtaskmanager.numberOfTaskSlots=4{code}
> Kubernetes should not have a CustomCommandLine.
> -----------------------------------------------
>
> Key: FLINK-15179
> URL: https://issues.apache.org/jira/browse/FLINK-15179
> Project: Flink
> Issue Type: Sub-task
> Components: Deployment / Kubernetes
> Affects Versions: 1.10.0
> Reporter: Kostas Kloudas
> Assignee: Kostas Kloudas
> Priority: Major
>
> As part of FLIP-73, all command line options are mapped to config options.
> Given this 1-to-1 mapping, the Kubernetes command line could simply forward
> the command line arguments to ConfigOptions directly, instead of introducing
> new command line options. In this case, the user is expected to simply write:
>
> {\{bin/run -e (or --executor) kubernetes-session-cluster -D
> kubernetes.container.image=MY_IMAGE ...}}
> and the CLI will parse the -e to figure out the correct
> {{ClusterClientFactory}} and {{ExecutorFactory}} and then forward to that the
> config options specified with {{-D}}.
> For this, we need to introduce a {{GenericCustomCommandLine}} that simply
> forward the specified parameters to the executors.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
