[
https://issues.apache.org/jira/browse/FLINK-15179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16994137#comment-16994137
]
Yang Wang commented on FLINK-15179:
-----------------------------------
[~kkl0u] I agree with you that it is a good solution. For
`kubernetes-session.sh -h` the help message could meet our requirement just
like following.
{code:java}
./bin/kubernetes-session.sh -h
Usage:
Optional
-d,--detached If present, runs the job
in detached mode
-D <property=value> use value for given
property
-h,--help Help for Kubernetes
session CLI.
-Dkubernetes.container.image <arg> Image to use for Flink
containers
-Dkubernetes.cluster-id <arg> The cluster id used for
identifying ...
-Djobmanager.heap.size <arg> Memory for JobManager ...
-Dtaskmanager.numberOfTaskSlots <arg> Number of slots per
TaskManager
-Dtaskmanager.memory.total-process.size <arg> Memory per
TaskManager...{code}
What will happen about `flink run -h` or `flink -h`. Do we need to add short
prefix "k" or long prefix "kubernetes"? Does each executor will have a
separated help message, for example "kubernetes-session-cluster" and
"kubernetes-job-cluster"? Currently, we do not differentiate the mode, per-job
or session.
> Kubernetes should not have a CustomCommandLine.
> -----------------------------------------------
>
> Key: FLINK-15179
> URL: https://issues.apache.org/jira/browse/FLINK-15179
> Project: Flink
> Issue Type: Sub-task
> Components: Deployment / Kubernetes
> Affects Versions: 1.10.0
> Reporter: Kostas Kloudas
> Assignee: Kostas Kloudas
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> As part of FLIP-73, all command line options are mapped to config options.
> Given this 1-to-1 mapping, the Kubernetes command line could simply forward
> the command line arguments to ConfigOptions directly, instead of introducing
> new command line options. In this case, the user is expected to simply write:
>
> {\{bin/run -e (or --executor) kubernetes-session-cluster -D
> kubernetes.container.image=MY_IMAGE ...}}
> and the CLI will parse the -e to figure out the correct
> {{ClusterClientFactory}} and {{ExecutorFactory}} and then forward to that the
> config options specified with {{-D}}.
> For this, we need to introduce a {{GenericCustomCommandLine}} that simply
> forward the specified parameters to the executors.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
