[
https://issues.apache.org/jira/browse/FLINK-15179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993502#comment-16993502
]
Kostas Kloudas commented on FLINK-15179:
----------------------------------------
It would contain the config options, as the goal is to have no specific cli
options for different CLIs. The {{ExecutorCLI}} will have a {{-h}} that based
on the {{-e}} it will pick the correct executor and this will provide the help
message.
I have not implemented something like that yet and it may require to add a
method to the executors that will give back the help message. But it seems like
a good solution.
> Kubernetes should not have a CustomCommandLine.
> -----------------------------------------------
>
> Key: FLINK-15179
> URL: https://issues.apache.org/jira/browse/FLINK-15179
> Project: Flink
> Issue Type: Sub-task
> Components: Deployment / Kubernetes
> Affects Versions: 1.10.0
> Reporter: Kostas Kloudas
> Assignee: Kostas Kloudas
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> As part of FLIP-73, all command line options are mapped to config options.
> Given this 1-to-1 mapping, the Kubernetes command line could simply forward
> the command line arguments to ConfigOptions directly, instead of introducing
> new command line options. In this case, the user is expected to simply write:
>
> {\{bin/run -e (or --executor) kubernetes-session-cluster -D
> kubernetes.container.image=MY_IMAGE ...}}
> and the CLI will parse the -e to figure out the correct
> {{ClusterClientFactory}} and {{ExecutorFactory}} and then forward to that the
> config options specified with {{-D}}.
> For this, we need to introduce a {{GenericCustomCommandLine}} that simply
> forward the specified parameters to the executors.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
