zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime]
Solve the potential deadlock problem when reducing exclusive buffers to zero
URL: https://github.com/apache/flink/pull/11351#discussion_r397601809
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierAligner.java
##########
@@ -318,6 +326,16 @@ public long getAlignmentDurationNanos() {
}
}
+ public void registerInputGate(CheckpointedInputGate inputGate) {
+ inputGates.add(checkNotNull(inputGate));
+ }
+
+ public void notifyCheckpointCompletedOrCanceled(long checkpointId) {
Review comment:
We might need to adjust this method naming, because it is not indicating for
the checkpoint really completed (the async checkpoint process).
`notifyUnblockInputChannels`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
