zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime]
Solve the potential deadlock problem when reducing exclusive buffers to zero
URL: https://github.com/apache/flink/pull/11351#discussion_r397602529
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierAligner.java
##########
@@ -318,6 +326,16 @@ public long getAlignmentDurationNanos() {
}
}
+ public void registerInputGate(CheckpointedInputGate inputGate) {
Review comment:
Another option is passing `inputGate` in constructor instead to avoid
exposing another methods outside. Otherwise in tests if someone constructs the
`CheckpointBarrierAligner`, but forgets to register gate afterwards, then the
gates are actually touched in the internal related processes to bring
unexpected behaviors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
