fapaul commented on a change in pull request #16838:
URL: https://github.com/apache/flink/pull/16838#discussion_r689448215



##########
File path: 
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/reader/KafkaPartitionSplitReader.java
##########
@@ -161,6 +171,13 @@ public KafkaPartitionSplitReader(
                                 finishedPartitions,
                                 recordsBySplits);
                     }
+                    // Update I/O metric
+                    sourceReaderMetricGroup
+                            .getIOMetricGroup()
+                            .getNumBytesInCounter()
+                            .inc(

Review comment:
       Maybe it is better to directly forward the Kafka metric 
https://github.com/apache/flink/commit/a1441c262f35407c4029f6ddf8daa18cd859f822#diff-026b7f554eb085f1d2dde933dcafa4bf39abd995dcb071126a545c9d9de109fbR41




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to