fapaul commented on a change in pull request #16838:
URL: https://github.com/apache/flink/pull/16838#discussion_r689616706
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/reader/KafkaPartitionSplitReader.java
##########
@@ -414,6 +431,30 @@ private void maybeRegisterKafkaConsumerMetrics(
}
}
+ private void registerPendingRecordsMetric(
+ SourceReaderMetricGroup metricGroup, KafkaConsumer<?, ?> consumer)
{
+
+ final String recordsLagMaxName = "records-lag-max";
Review comment:
It can definitely be misleading when multiplying it in the case you've
mentioned but on the other hand in the current situation, it is misleading if
all assigned partitions lag equally behind. The `pendingRecords` would only
account for one partition although the correct lag is up to partitions *
`records-max-lag`.
Personally, I can also think of not implementing this metric now and
separate it from this PR.
WDYT @AHeise?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
