PatrickRen commented on a change in pull request #16838:
URL: https://github.com/apache/flink/pull/16838#discussion_r689524065
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/reader/KafkaPartitionSplitReader.java
##########
@@ -414,6 +431,30 @@ private void maybeRegisterKafkaConsumerMetrics(
}
}
+ private void registerPendingRecordsMetric(
+ SourceReaderMetricGroup metricGroup, KafkaConsumer<?, ?> consumer)
{
+
+ final String recordsLagMaxName = "records-lag-max";
Review comment:
Thanks for the careful review! This is really annoying... I'm not sure
if that worth it to use additional data structures and maybe affect performance
to implement just one metric. Is there any suggestions for
```pendingRecords```? Otherwise I prefer to skip it for now 😢
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
