PatrickRen commented on a change in pull request #16838:
URL: https://github.com/apache/flink/pull/16838#discussion_r689610451
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/reader/KafkaPartitionSplitReader.java
##########
@@ -414,6 +431,30 @@ private void maybeRegisterKafkaConsumerMetrics(
}
}
+ private void registerPendingRecordsMetric(
+ SourceReaderMetricGroup metricGroup, KafkaConsumer<?, ?> consumer)
{
+
+ final String recordsLagMaxName = "records-lag-max";
Review comment:
I think multiplying with #partition is a bit too inaccurate. If messages
among subscribed partitions are imbalanced, the value of ```pendingRecords```
will be quite misleading to users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
