PatrickRen commented on a change in pull request #16838:
URL: https://github.com/apache/flink/pull/16838#discussion_r689649174



##########
File path: 
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/reader/KafkaPartitionSplitReader.java
##########
@@ -414,6 +433,40 @@ private void maybeRegisterKafkaConsumerMetrics(
         }
     }
 
+    private Supplier<Long> getBytesConsumedTotalSupplier(KafkaConsumer<?, ?> 
consumer) {

Review comment:
       The compiler complains a warn if I use ```Optional``` as a class field 🤔 
I'd like to keep it for now (forgive me being neat-freak lol)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to