[
https://issues.apache.org/jira/browse/FLINK-4191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15370889#comment-15370889
]
ASF GitHub Bot commented on FLINK-4191:
---------------------------------------
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2225#discussion_r70269570
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/serialization/KinesisDeserializationSchema.java
---
@@ -43,7 +44,7 @@
* @return the deserialized message as an Java object
* @throws IOException
*/
- T deserialize(byte[] recordKey, byte[] recordValue, String stream,
String seqNum, long approxArrivalTimestamp) throws IOException;
+ T deserialize(byte[] recordKey, byte[] recordValue, String stream,
Shard shard, String seqNum, long approxArrivalTimestamp) throws IOException;
--- End diff --
Can you also update the Javadoc for this method?
> Expose shard information in KinesisDeserializationSchema
> --------------------------------------------------------
>
> Key: FLINK-4191
> URL: https://issues.apache.org/jira/browse/FLINK-4191
> Project: Flink
> Issue Type: Sub-task
> Components: Kinesis Connector, Streaming Connectors
> Affects Versions: 1.1.0
> Reporter: Robert Metzger
> Assignee: Robert Metzger
> Fix For: 1.1.0
>
>
> Currently, we are not exposing the Shard ID and other shard-related
> information in the deserialization schema.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
