[
https://issues.apache.org/jira/browse/FLINK-4191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15371330#comment-15371330
]
ASF GitHub Bot commented on FLINK-4191:
---------------------------------------
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2225#discussion_r70308410
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
---
@@ -206,7 +206,13 @@ private void
deserializeRecordForCollectionAndUpdateState(UserRecord record)
final long approxArrivalTimestamp =
record.getApproximateArrivalTimestamp().getTime();
final T value = deserializer.deserialize(
- keyBytes, dataBytes, subscribedShard.getStreamName(),
record.getSequenceNumber(), approxArrivalTimestamp);
+ keyBytes,
+ dataBytes,
+ record.getPartitionKey(),
+ record.getSequenceNumber(),
+ approxArrivalTimestamp,
+ subscribedShard.getStreamName(),
+ subscribedShard.getShard().getShardId());
--- End diff --
`subscribedShard.getStreamName()` and
`subscribedShard.getShard().getShardId()` will be the same for all records
collected in the while loop. Probably won't have a big performance difference,
but perhaps it would be better to have `final` values for these two to point
out this fact?
> Expose shard information in KinesisDeserializationSchema
> --------------------------------------------------------
>
> Key: FLINK-4191
> URL: https://issues.apache.org/jira/browse/FLINK-4191
> Project: Flink
> Issue Type: Sub-task
> Components: Kinesis Connector, Streaming Connectors
> Affects Versions: 1.1.0
> Reporter: Robert Metzger
> Assignee: Robert Metzger
> Fix For: 1.1.0
>
>
> Currently, we are not exposing the Shard ID and other shard-related
> information in the deserialization schema.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
