[
https://issues.apache.org/jira/browse/FLINK-4191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15371269#comment-15371269
]
ASF GitHub Bot commented on FLINK-4191:
---------------------------------------
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2225#discussion_r70303482
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/serialization/KinesisDeserializationSchema.java
---
@@ -37,13 +37,15 @@
*
* @param recordKey the records's key as a byte array (null if no key
has been set for the record)
* @param recordValue the record's value as a byte array
- * @param stream the name of the Kinesis stream that this record was
sent to
+ * @param partitionKey the record's partition key at the time of
writing.
* @param seqNum the sequence number of this record in the Kinesis shard
* @param approxArrivalTimestamp the server-side timestamp of when
Kinesis received and stored the record
+ * @param stream the name of the Kinesis stream that this record was
sent to
+ * @param shardId The identifier of the shard the record was sent to.
--- End diff --
nit: some param descriptions end with period, some don't. I think the
others all don't end with period, let's keep consistent with that.
> Expose shard information in KinesisDeserializationSchema
> --------------------------------------------------------
>
> Key: FLINK-4191
> URL: https://issues.apache.org/jira/browse/FLINK-4191
> Project: Flink
> Issue Type: Sub-task
> Components: Kinesis Connector, Streaming Connectors
> Affects Versions: 1.1.0
> Reporter: Robert Metzger
> Assignee: Robert Metzger
> Fix For: 1.1.0
>
>
> Currently, we are not exposing the Shard ID and other shard-related
> information in the deserialization schema.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
