[
https://issues.apache.org/jira/browse/FLINK-4191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15371278#comment-15371278
]
ASF GitHub Bot commented on FLINK-4191:
---------------------------------------
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2225#discussion_r70304158
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/serialization/KinesisDeserializationSchemaWrapper.java
---
@@ -37,15 +37,15 @@ public
KinesisDeserializationSchemaWrapper(DeserializationSchema<T> deserializat
}
@Override
- public T deserialize(byte[] recordKey, byte[] recordValue, String
stream, String seqNum, long approxArrivalTimestamp)
+ public T deserialize(byte[] recordKey, byte[] recordValue, String
partitionKey, String seqNum, long approxArrivalTimestamp, String stream, String
shardId)
throws IOException {
return deserializationSchema.deserialize(recordValue);
}
- @Override
+ /*@Override
public boolean isEndOfStream(T nextElement) {
return deserializationSchema.isEndOfStream(nextElement);
- }
+ } */
--- End diff --
Not sure if we should have commented out code. Open up a JIRA for this
instead?
> Expose shard information in KinesisDeserializationSchema
> --------------------------------------------------------
>
> Key: FLINK-4191
> URL: https://issues.apache.org/jira/browse/FLINK-4191
> Project: Flink
> Issue Type: Sub-task
> Components: Kinesis Connector, Streaming Connectors
> Affects Versions: 1.1.0
> Reporter: Robert Metzger
> Assignee: Robert Metzger
> Fix For: 1.1.0
>
>
> Currently, we are not exposing the Shard ID and other shard-related
> information in the deserialization schema.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
