[
https://issues.apache.org/jira/browse/FLINK-4191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15371289#comment-15371289
]
ASF GitHub Bot commented on FLINK-4191:
---------------------------------------
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2225#discussion_r70305936
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/serialization/KinesisDeserializationSchema.java
---
@@ -52,5 +54,5 @@
* @param nextElement the element to test for the end-of-stream signal
* @return true if the element signals end of stream, false otherwise
*/
- boolean isEndOfStream(T nextElement);
+ // TODO ADD SUPPORT FOR boolean isEndOfStream(T nextElement);
--- End diff --
Ah, I just noticed the JIRA for this. Let's leave it as it is then, and
uncomment it for the fix on that JIRA.
> Expose shard information in KinesisDeserializationSchema
> --------------------------------------------------------
>
> Key: FLINK-4191
> URL: https://issues.apache.org/jira/browse/FLINK-4191
> Project: Flink
> Issue Type: Sub-task
> Components: Kinesis Connector, Streaming Connectors
> Affects Versions: 1.1.0
> Reporter: Robert Metzger
> Assignee: Robert Metzger
> Fix For: 1.1.0
>
>
> Currently, we are not exposing the Shard ID and other shard-related
> information in the deserialization schema.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
