XComp commented on a change in pull request #18189: URL: https://github.com/apache/flink/pull/18189#discussion_r781090363
########## File path: flink-core/src/main/java/org/apache/flink/util/function/QuintFunction.java ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.util.function; + +import org.apache.flink.annotation.PublicEvolving; + +/** + * Function which takes three arguments. + * + * @param <S> type of the first argument + * @param <T> type of the second argument + * @param <U> type of the third argument + * @param <V> type of the fourth argument + * @param <W> type of the fifth argument + * @param <R> type of the return value + */ +@PublicEvolving +@FunctionalInterface +public interface QuintFunction<S, T, U, V, W, R> { Review comment: Can you clarify what you mean by "with five parameters, implementations are just too complex without parameter names"? You have to specify the parameter list when applying this class in any way (i.e. when using the actual interface or when using this generic Function). 🤔 But besides that, I agree that `TestingDispatcherGatewayServiceFactory` does not add any value: I'm going to remove the `QuintFunction*` interfaces again and use `AbstractDispatcherLeaderProcess.DispatcherGatewayServiceFactory` as is in `SessionDispatcherLeaderProcessTest`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
