XComp commented on a change in pull request #18189:
URL: https://github.com/apache/flink/pull/18189#discussion_r781378562
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/MiniDispatcher.java
##########
@@ -63,6 +63,7 @@ public MiniDispatcher(
rpcService,
fencingToken,
Collections.singleton(jobGraph),
+ Collections.emptyList(),
Review comment:
No, it's not. Good catch. I put these in as placeholders to finish one
code branch first and forgot about it then -.-.
But that brings up a question: Shall we try to clean all dirty jobs in a job
cluster or only the job of this specific cluster? I'm thinking about a use-case
where somebody uses the same `JobResultStore` for multiple job clusters. I see
two options:
* The cleanup is only in charge of cleaning up the cluster's job.
* The cleanup picks up all dirty jobs unrelated to whether their job ID
belongs to the job cluster's job or not.
I tend to prefer the latter option. Because I'd assume (without any
evidence, though) that it would be more of a theoretical case? 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
