XComp commented on a change in pull request #18189:
URL: https://github.com/apache/flink/pull/18189#discussion_r781204397
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
##########
@@ -196,6 +198,8 @@ public Dispatcher(
this.recoveredJobs = new HashSet<>(recoveredJobs);
+ this.globallyTerminatedJobs = new HashSet<>(globallyTerminatedJobs);
Review comment:
These collections are cleared after the corresponding `JobManagerRunner`
is created. The motivation behind that was, I guess, to save memory which
sounds reasonable to me. If that's the case, using immutable sets for the
`recoveredJobs` isn't a good idea.
I treated the `globallyTerminatedJobs` in the same way for consistency
reasons. We could switch to an immutable set for the `globallyTerminatedJobs`
member. But I don't see us gaining much from it. I'd rather prefer having it
done analogously, instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
