fapaul commented on code in PR #19633:
URL: https://github.com/apache/flink/pull/19633#discussion_r864782675
##########
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/hybrid/HybridSource.java:
##########
@@ -108,18 +109,21 @@ public Boundedness getBoundedness() {
return sources.get(sources.size() - 1).boundedness;
}
+ @Internal
Review Comment:
I think one important piece that is currently missing in Flink's annotation
is the difference between **usage** and **implementations**. From a base
interface perspective, connector developers are supposed to implement the
method therefore it is not internal but from a user perspective, it is internal
because no user should ever interact with the method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
