zentol commented on code in PR #19633:
URL: https://github.com/apache/flink/pull/19633#discussion_r864786891
##########
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/hybrid/HybridSource.java:
##########
@@ -108,18 +109,21 @@ public Boundedness getBoundedness() {
return sources.get(sources.size() - 1).boundedness;
}
+ @Internal
Review Comment:
That is indeed something that we're missing. We discussed it a while ago and
couldn't come up with a definitive answer.
I'd like to avoid trying to work around it this way.
In practice you can't make a breaking change to this method anyway because
the method is still public as defined by the interface (so we don't gain any
flexibility to change stuff) nor can you make any assumption that this method
is not called because hey, a user might just work against the Source interface
where this method is public.
So...I don't see us gaining anything really.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
