zentol commented on code in PR #19633:
URL: https://github.com/apache/flink/pull/19633#discussion_r864819082
##########
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/hybrid/HybridSource.java:
##########
@@ -108,18 +109,21 @@ public Boundedness getBoundedness() {
return sources.get(sources.size() - 1).boundedness;
}
+ @Internal
Review Comment:
> We did this approach already for a lot of connectors
Do we? Can you point me to some discussion where we agreed to do this?
> the connector gives no guarantee about maintaining the compatibility i.e.
the returned serializer changes.
But the connector can already change whatever it returns so long as it
adheres to the interface. I could see issues where the return type is a
connector-specific implementation, although then I wonder whether this is
actually correct / necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
