fapaul commented on code in PR #19633:
URL: https://github.com/apache/flink/pull/19633#discussion_r864800518


##########
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/hybrid/HybridSource.java:
##########
@@ -108,18 +109,21 @@ public Boundedness getBoundedness() {
         return sources.get(sources.size() - 1).boundedness;
     }
 
+    @Internal

Review Comment:
   What is your proposal? We did this approach already for a lot of connectors 
and so far it made sense. Of course, users can still interact with these 
methods but the connector gives no guarantee about maintaining the 
compatibility i.e. the returned serializer changes. Currently, I see two 
options do it like this or keep the existing violations.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to