fapaul commented on code in PR #19633:
URL: https://github.com/apache/flink/pull/19633#discussion_r865816365
##########
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/hybrid/HybridSource.java:
##########
@@ -108,18 +109,21 @@ public Boundedness getBoundedness() {
return sources.get(sources.size() - 1).boundedness;
}
+ @Internal
Review Comment:
> Good god it actually seems necessary; e.g., KafkaSink#createWriter
actually implements 2 distinct interfaces at once 🤯.
That was one of the design decisions for the new interface. That connector
developer can choose which methods to implement and make it transparent for the
end-user. Indeed that reduces a bit the readability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
