gyfora opened a new pull request, #501:
URL: https://github.com/apache/flink-kubernetes-operator/pull/501
## What is the purpose of the change
This is the bigger refactor PR that does not introduce any functional
changes.
The main purpose of the change is to consolidate the scattered resource,
config and flinkservice handling into a unified `FlinkResourceContext` object.
This makes the both the `Observer` and `Reconciler` implementations much
simpler, more testable and more efficient. Configs, metric groups and
flinkService implementations are now created in a single place and are carried
throughout the reconcile loop.
Tests have also been improved by introducing a shared `OperatorTestBase` for
reconciler and observer based tests in order to simplify context handling and
factor out shared code from the tests.
## Verifying this change
This change is already covered by the existing unit tests as we have not
introduced new functionality.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changes to the `CustomResourceDescriptors`:
no
- Core observer or reconciler logic that is regularly executed: yes
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
