gyfora commented on code in PR #501: URL: https://github.com/apache/flink-kubernetes-operator/pull/501#discussion_r1062519064
########## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/controller/FlinkResourceContext.java: ########## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.kubernetes.operator.controller; + +import org.apache.flink.configuration.Configuration; +import org.apache.flink.kubernetes.operator.api.AbstractFlinkResource; +import org.apache.flink.kubernetes.operator.api.spec.AbstractFlinkSpec; +import org.apache.flink.kubernetes.operator.metrics.KubernetesResourceMetricGroup; +import org.apache.flink.kubernetes.operator.service.FlinkService; + +import io.javaoperatorsdk.operator.api.reconciler.Context; +import lombok.Getter; +import lombok.RequiredArgsConstructor; + +/** Context for reconciling a Flink resource. * */ +@RequiredArgsConstructor +public abstract class FlinkResourceContext<CR extends AbstractFlinkResource<?, ?>> { + + @Getter private final CR resource; + @Getter private final Context<?> josdkContext; + @Getter private final KubernetesResourceMetricGroup resourceMetricGroup; + + private Configuration observeConfig; + + /** + * Get the config that is currently deployed for the resource spec. + * + * @return Config currently deployed. + */ + public Configuration getObserveConfig() { + if (observeConfig != null) { + return observeConfig; + } + return observeConfig = createObserveConfig(); + } + + /** + * Get Flink configuration object for deploying the given spec using {@link + * org.apache.flink.kubernetes.operator.reconciler.deployment.AbstractFlinkResourceReconciler#deploy}. + * + * @param spec Spec for which the config should be created. + * @return Deployment configuration. Review Comment: Sure, I will add a note here, however if we get a null then something is not right in most cases. we should explicitly check if the session is ready before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
