gyfora commented on code in PR #501:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/501#discussion_r1062521734
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/SavepointObserver.java:
##########
@@ -139,7 +137,10 @@ private void observeTriggeredSavepoint(
/** Clean up and dispose savepoints according to the configured max
size/age. */
@VisibleForTesting
- void cleanupSavepointHistory(SavepointInfo currentSavepointInfo,
Configuration deployedConfig) {
+ void cleanupSavepointHistory(
+ FlinkService flinkService,
+ SavepointInfo currentSavepointInfo,
+ Configuration observeConfig) {
Review Comment:
based on your offline comments I renamed deployedConfig to obsserveConfig to
unify the naming. No behaviour change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
