gyfora commented on code in PR #501: URL: https://github.com/apache/flink-kubernetes-operator/pull/501#discussion_r1062525100
########## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkResourceContextFactory.java: ########## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.kubernetes.operator.service; + +import org.apache.flink.annotation.VisibleForTesting; +import org.apache.flink.api.java.tuple.Tuple2; +import org.apache.flink.kubernetes.operator.api.AbstractFlinkResource; +import org.apache.flink.kubernetes.operator.api.FlinkDeployment; +import org.apache.flink.kubernetes.operator.api.FlinkSessionJob; +import org.apache.flink.kubernetes.operator.api.spec.KubernetesDeploymentMode; +import org.apache.flink.kubernetes.operator.config.FlinkConfigManager; +import org.apache.flink.kubernetes.operator.controller.FlinkDeploymentContext; +import org.apache.flink.kubernetes.operator.controller.FlinkResourceContext; +import org.apache.flink.kubernetes.operator.controller.FlinkSessionJobContext; +import org.apache.flink.kubernetes.operator.metrics.KubernetesOperatorMetricGroup; +import org.apache.flink.kubernetes.operator.metrics.KubernetesResourceMetricGroup; +import org.apache.flink.kubernetes.operator.metrics.OperatorMetricUtils; + +import io.fabric8.kubernetes.client.KubernetesClient; +import io.javaoperatorsdk.operator.api.reconciler.Context; +import io.javaoperatorsdk.operator.processing.event.ResourceID; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.Map; +import java.util.concurrent.ConcurrentHashMap; + +/** Factory for creating the {@link FlinkResourceContext}. */ +public class FlinkResourceContextFactory { + + private static final Logger LOG = LoggerFactory.getLogger(FlinkResourceContextFactory.class); + + private final KubernetesClient kubernetesClient; + private final FlinkConfigManager configManager; + private final KubernetesOperatorMetricGroup operatorMetricGroup; + private final Map<KubernetesDeploymentMode, FlinkService> serviceMap; + + private final Map<Tuple2<Class<?>, ResourceID>, KubernetesResourceMetricGroup> + resourceMetricGroups = new ConcurrentHashMap<>(); + + public FlinkResourceContextFactory( + KubernetesClient kubernetesClient, + FlinkConfigManager configManager, + KubernetesOperatorMetricGroup operatorMetricGroup) { + this.kubernetesClient = kubernetesClient; + this.configManager = configManager; + this.operatorMetricGroup = operatorMetricGroup; + this.serviceMap = new ConcurrentHashMap<>(); + } + + public <CR extends AbstractFlinkResource<?, ?>> FlinkResourceContext<CR> getResourceContext( + CR resource, Context josdkContext) { + var resMg = + resourceMetricGroups.computeIfAbsent( + Tuple2.of(resource.getClass(), ResourceID.fromResource(resource)), + r -> + OperatorMetricUtils.createResourceMetricGroup( + operatorMetricGroup, configManager, resource)); + + if (resource instanceof FlinkDeployment) { + var flinkDep = (FlinkDeployment) resource; + return (FlinkResourceContext<CR>) + new FlinkDeploymentContext( + flinkDep, + josdkContext, + resMg, + getOrCreateFlinkService(flinkDep), + configManager); + } else if (resource instanceof FlinkSessionJob) { + return (FlinkResourceContext<CR>) + new FlinkSessionJobContext( + (FlinkSessionJob) resource, josdkContext, resMg, this, configManager); + } else { + throw new IllegalArgumentException( + "Unknown resource type " + resource.getClass().getSimpleName()); + } Review Comment: This is a factory that returns resource specific implementations in a generic way. I could add 2 create methods one for FlinkDeployment and one for FlinkSessionJob but I don't think the `instanceof` is too bad. Do you have a concrete suggestion that would make this cleaner? (without a bunch of extra boilerplate) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
