gyfora commented on code in PR #501:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/501#discussion_r1062519840
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/ApplicationReconciler.java:
##########
@@ -159,23 +133,23 @@ private void deleteJmThatNeverStarted(FlinkDeployment
deployment, Configuration
}
@Override
- protected void deploy(
- FlinkDeployment relatedResource,
+ public void deploy(
+ FlinkResourceContext<FlinkDeployment> ctx,
FlinkDeploymentSpec spec,
- FlinkDeploymentStatus status,
- Context<?> ctx,
Configuration deployConfig,
Optional<String> savepoint,
boolean requireHaMetadata)
throws Exception {
+ var relatedResource = ctx.getResource();
+ var status = relatedResource.getStatus();
if (savepoint.isPresent()) {
deployConfig.set(SavepointConfigOptions.SAVEPOINT_PATH,
savepoint.get());
} else {
deployConfig.removeConfig(SavepointConfigOptions.SAVEPOINT_PATH);
}
- setOwnerReference(relatedResource, deployConfig);
+ setOwnerReference(ctx.getResource(), deployConfig);
Review Comment:
no, I was just trying to not change the method too much and failed. I will
replace with `relatedResource `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
