snuyanzin commented on code in PR #22632:
URL: https://github.com/apache/flink/pull/22632#discussion_r1204185544
##########
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/ZKCheckpointIDCounterMultiServersTest.java:
##########
@@ -48,11 +49,12 @@ public final class ZKCheckpointIDCounterMultiServersTest
extends TestLogger {
* <p>See also FLINK-14091.
*/
@Test
- public void testRecoveredAfterConnectionLoss() throws Exception {
+ void testRecoveredAfterConnectionLoss() throws Exception {
final Configuration configuration = new Configuration();
configuration.setString(
- HighAvailabilityOptions.HA_ZOOKEEPER_QUORUM,
zooKeeperResource.getConnectString());
+ HighAvailabilityOptions.HA_ZOOKEEPER_QUORUM,
+
zookeeperExtensionWrapper.getCustomExtension().getConnectString());
final CuratorFrameworkWithUnhandledErrorListener
curatorFrameworkWrapper =
ZooKeeperUtils.startCuratorFramework(configuration,
NoOpFatalErrorHandler.INSTANCE);
Review Comment:
Doesn't it make sense to put `ZooKeeperUtils.startCuratorFramework` into
`try` to use automatic resource mngmt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
