snuyanzin commented on code in PR #22632:
URL: https://github.com/apache/flink/pull/22632#discussion_r1204214134
##########
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/runner/DefaultDispatcherRunnerITCase.java:
##########
@@ -173,8 +175,7 @@ private DispatcherGateway
electLeaderAndRetrieveGateway(UUID firstLeaderSessionI
* fail.
*/
@Test
- public void
leaderChange_withBlockingJobManagerTermination_doesNotAffectNewLeader()
- throws Exception {
+ void
leaderChange_withBlockingJobManagerTermination_doesNotAffectNewLeader() throws
Exception {
final TestingJobMasterServiceLeadershipRunnerFactory
jobManagerRunnerFactory =
new TestingJobMasterServiceLeadershipRunnerFactory(1);
final TestingCleanupRunnerFactory cleanupRunnerFactory = new
TestingCleanupRunnerFactory();
Review Comment:
Here below similar question about `dispatcherRunner` whether we need it or
not... (in case yes... may just add a comment)
And at the same time there is
```java
final TestingJobManagerRunner testingJobManagerRunner =
jobManagerRunnerFactory.takeCreatedJobManagerRunner();
```
where some resources are opened without closing... may be put it in `try`
resource
##########
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/runner/DefaultDispatcherRunnerITCase.java:
##########
@@ -121,18 +120,20 @@ public void setup() {
partialDispatcherServices =
TestingPartialDispatcherServices.builder()
.withFatalErrorHandler(fatalErrorHandler)
- .build(blobServerResource.getBlobServer(), new
Configuration());
+ .build(
+
blobServerExtensionWrapper.getCustomExtension().getBlobServer(),
+ new Configuration());
}
- @After
- public void teardown() throws Exception {
+ @AfterEach
+ void teardown() throws Exception {
if (fatalErrorHandler != null) {
fatalErrorHandler.rethrowError();
}
}
@Test
- public void leaderChange_afterJobSubmission_recoversSubmittedJob() throws
Exception {
+ void leaderChange_afterJobSubmission_recoversSubmittedJob() throws
Exception {
try (final DispatcherRunner dispatcherRunner =
createDispatcherRunner()) {
Review Comment:
just wonder whether we need `dispatcherRunner` here? It seems it is not used
anywhere
(in case yes... may just add a comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
