snuyanzin commented on code in PR #22632:
URL: https://github.com/apache/flink/pull/22632#discussion_r1204218723
##########
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/runner/ZooKeeperDefaultDispatcherRunnerTest.java:
##########
@@ -144,8 +147,9 @@ public void teardown() throws Exception {
/** See FLINK-11665. */
@Test
- public void testResourceCleanupUnderLeadershipChange() throws Exception {
- final TestingRpcService rpcService =
testingRpcServiceResource.getTestingRpcService();
+ void testResourceCleanupUnderLeadershipChange() throws Exception {
+ final TestingRpcService rpcService =
+
testingRpcServiceExtensionWrapper.getCustomExtension().getTestingRpcService();
final TestingLeaderElectionService dispatcherLeaderElectionService =
new TestingLeaderElectionService();
Review Comment:
should we also put `ZooKeeperUtils.startCuratorFramework` which is one line
below to `try` resource?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
