snuyanzin commented on code in PR #22632:
URL: https://github.com/apache/flink/pull/22632#discussion_r1204207913
##########
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/ZooKeeperCompletedCheckpointStoreTest.java:
##########
@@ -232,12 +232,13 @@ public long getStateSize() {
* (i.e., there exists an exception thrown by the method).
*/
@Test
- public void testAddCheckpointWithFailedRemove() throws Exception {
+ void testAddCheckpointWithFailedRemove() throws Exception {
final int numCheckpointsToRetain = 1;
final Configuration configuration = new Configuration();
configuration.setString(
- HighAvailabilityOptions.HA_ZOOKEEPER_QUORUM,
zooKeeperResource.getConnectString());
+ HighAvailabilityOptions.HA_ZOOKEEPER_QUORUM,
+
zooKeeperExtensionWrapper.getCustomExtension().getConnectString());
final CuratorFrameworkWithUnhandledErrorListener
curatorFrameworkWrapper =
ZooKeeperUtils.startCuratorFramework(configuration,
NoOpFatalErrorHandler.INSTANCE);
Review Comment:
it seems here `ZooKeeperUtils.startCuratorFramework` opens resources and
doesn't close it.. May be put it in `try` resources block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
