snuyanzin commented on code in PR #22632:
URL: https://github.com/apache/flink/pull/22632#discussion_r1204210551
##########
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/runner/DefaultDispatcherRunnerITCase.java:
##########
@@ -121,18 +120,20 @@ public void setup() {
partialDispatcherServices =
TestingPartialDispatcherServices.builder()
.withFatalErrorHandler(fatalErrorHandler)
- .build(blobServerResource.getBlobServer(), new
Configuration());
+ .build(
+
blobServerExtensionWrapper.getCustomExtension().getBlobServer(),
+ new Configuration());
}
- @After
- public void teardown() throws Exception {
+ @AfterEach
+ void teardown() throws Exception {
if (fatalErrorHandler != null) {
fatalErrorHandler.rethrowError();
}
}
@Test
- public void leaderChange_afterJobSubmission_recoversSubmittedJob() throws
Exception {
+ void leaderChange_afterJobSubmission_recoversSubmittedJob() throws
Exception {
try (final DispatcherRunner dispatcherRunner =
createDispatcherRunner()) {
Review Comment:
just wonder whether we need `dispatcherRunner` here? It seems it is not used
anywhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
