gyfora commented on code in PR #685:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/685#discussion_r1365655692
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/event/AutoScalerEventHandler.java:
##########
@@ -33,19 +35,15 @@
@Experimental
public interface AutoScalerEventHandler<KEY, Context extends
JobAutoScalerContext<KEY>> {
- /**
- * Handle the event.
- *
- * @param interval When interval is great than 0, events that repeat
within the interval will be
- * ignored.
- */
+ /** Handle the event. */
Review Comment:
I think the entire eventHandler interface is getting pretty weird. It was
already not very nice before this change but now it's even worse because we are
leaking too many internals of the operator event triggering mechanism.
I think we need to break up the handleEvent into two new methods.
```
// Would be the current logic but without the interval logic
handleGenericAutoscalerEvent(...)
// Handle scaling events separately. Then the operator can hide the complex
interval/label triggering logic
handleScalingEvent(Context, Map<JobVertexID, ScalingSummary>
scalingSummaries, scalingEnabled)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
