clarax commented on code in PR #685:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/685#discussion_r1365727935
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/event/AutoScalerEventHandler.java:
##########
@@ -33,19 +35,15 @@
@Experimental
public interface AutoScalerEventHandler<KEY, Context extends
JobAutoScalerContext<KEY>> {
- /**
- * Handle the event.
- *
- * @param interval When interval is great than 0, events that repeat
within the interval will be
- * ignored.
- */
+ /** Handle the event. */
Review Comment:
Thank you for calling out. I was not sure if I should have a separate
method, not sure what this handler interfaceshould be handing. We can move the
logic of handleGenericAutoscalerEven to the interface and make it an abstract
class. What do you think? @gyfora
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
