1996fanrui commented on code in PR #685:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/685#discussion_r1366621112
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/event/AutoScalerEventHandler.java:
##########
@@ -33,19 +35,15 @@
@Experimental
public interface AutoScalerEventHandler<KEY, Context extends
JobAutoScalerContext<KEY>> {
- /**
- * Handle the event.
- *
- * @param interval When interval is great than 0, events that repeat
within the interval will be
- * ignored.
- */
+ /** Handle the event. */
Review Comment:
The reason for removing the interval from this interface is because interval
just works for kubernetesEventHandler, right?
I wanna whether it's needed for Standalone Autoscaler, if it's needed, we
should keep the `interval` here.
Actually, I prefer keep it first. And removing it if we are sure it's really
not needed in the future. WDYT? cc @gyfora
Also, if the interval is not needed here.
`AutoScalerOptions#SCALING_REPORT_INTERVAL` should be moved into
`flink-kubernetes-operator` module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
