gyfora commented on code in PR #685:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/685#discussion_r1365742349
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/event/AutoScalerEventHandler.java:
##########
@@ -33,19 +35,15 @@
@Experimental
public interface AutoScalerEventHandler<KEY, Context extends
JobAutoScalerContext<KEY>> {
- /**
- * Handle the event.
- *
- * @param interval When interval is great than 0, events that repeat
within the interval will be
- * ignored.
- */
+ /** Handle the event. */
Review Comment:
I don't understand the suggestion @clarax what do you think my proposal?
Have those 2 methods in the interface and add a default implementation for
`handleScalingEvent`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
