gyfora commented on code in PR #685:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/685#discussion_r1367164471
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/event/AutoScalerEventHandler.java:
##########
@@ -33,19 +35,15 @@
@Experimental
public interface AutoScalerEventHandler<KEY, Context extends
JobAutoScalerContext<KEY>> {
- /**
- * Handle the event.
- *
- * @param interval When interval is great than 0, events that repeat
within the interval will be
- * ignored.
- */
+ /** Handle the event. */
Review Comment:
I still think it's better to pass Interval / scalingEnabled directly. They
are part of the intended behaviour of the method. If we don't pass it, we rely
on implementers to figure out how exactly to get this from the config. It would
be super easy to miss and come up with an incorrect implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
