dzikosc commented on code in PR #152:
URL:
https://github.com/apache/flink-connector-aws/pull/152#discussion_r1757368121
##########
flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/table/DynamoDbDynamicSinkFactory.java:
##########
@@ -58,6 +58,17 @@ public DynamicTableSink createDynamicTableSink(Context
context) {
.setDynamoDbClientProperties(
dynamoDbConfiguration.getSinkClientProperties());
+ if (catalogTable.getResolvedSchema().getPrimaryKey().isPresent()) {
+ builder =
+ builder.setPrimaryKeys(
+ new HashSet<>(
Review Comment:
DynamoDB primary key is an ordered set of properties - partitionKey and then
sortKey. Let's model it like that.
I would suggest using those as dedicated properties instead in the Sink
model. We could add an extra validation here to ensure consistency with DDB
schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
