nicusX commented on code in PR #152:
URL:
https://github.com/apache/flink-connector-aws/pull/152#discussion_r1765718042
##########
flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/table/DynamoDbDynamicSinkFactory.java:
##########
@@ -58,6 +58,17 @@ public DynamicTableSink createDynamicTableSink(Context
context) {
.setDynamoDbClientProperties(
dynamoDbConfiguration.getSinkClientProperties());
+ if (catalogTable.getResolvedSchema().getPrimaryKey().isPresent()) {
+ builder =
+ builder.setPrimaryKeys(
+ new HashSet<>(
Review Comment:
Ack for not having an object with separate fields.
However, in this case the `primaryKey` (singular) should be an ordered set
(e.g. a List) and not a Set. The order of the two fields is relevant: the first
always being the *partitionKey*, in DDB parlance, and the second, if present,
the *sortKey*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
