dzikosc commented on code in PR #152:
URL:
https://github.com/apache/flink-connector-aws/pull/152#discussion_r1757386924
##########
flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/table/DynamoDbDynamicSinkFactory.java:
##########
@@ -58,6 +58,17 @@ public DynamicTableSink createDynamicTableSink(Context
context) {
.setDynamoDbClientProperties(
dynamoDbConfiguration.getSinkClientProperties());
+ if (catalogTable.getResolvedSchema().getPrimaryKey().isPresent()) {
Review Comment:
IN case of DynamoDB contents of PrimaryKey and PARTITION BY should be the
same to ensure semantic correctness of various operations.
To avoid repetititiveness and simplify the usage, we should aim to use just
PrimaryKey property, as it's a fairly intuitive and well understood concept for
DDB users. In the meantime, we should probably aim to start deprecation process
of the `partition by` mechanism.
The first step could be
- if PK is set, but `partition by` is not, use PK as `partition by`
- document that `partition by` is on deprecation path
- log warnings when `partition by` is being used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
