robg-eb commented on code in PR #152:
URL:
https://github.com/apache/flink-connector-aws/pull/152#discussion_r1765712462
##########
flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/table/DynamoDbDynamicSinkFactory.java:
##########
@@ -58,6 +58,17 @@ public DynamicTableSink createDynamicTableSink(Context
context) {
.setDynamoDbClientProperties(
dynamoDbConfiguration.getSinkClientProperties());
+ if (catalogTable.getResolvedSchema().getPrimaryKey().isPresent()) {
Review Comment:
@dzikosc - Isn't there a potential use case wherein a user of the existing
`PARTITION BY` functionality of the sink wants to use it to deduplicate data by
something other than the actual Primary Key of the DynamoDB table? For
example, the DynamoDB table has:
```
user_id Partition Key
order_id Sort Key
line_number
price
```
Today, the user of the connector could specify a `PARTITION BY user_id,
order_id, line_number` to deduplicate incoming data - Maybe this is a contrived
case, but just pointing out that we may now be blocking a use case that was
previously supported. Thoughts?
Either way, could we keep the deprecation of `PARTITION BY` to a separate PR
to reduce the scope of this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
