robg-eb commented on code in PR #152:
URL:
https://github.com/apache/flink-connector-aws/pull/152#discussion_r1765691788
##########
flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/table/DynamoDbDynamicSink.java:
##########
@@ -62,7 +63,8 @@ protected DynamoDbDynamicSink(
boolean failOnError,
Properties dynamoDbClientProperties,
DataType physicalDataType,
- Set<String> overwriteByPartitionKeys) {
+ Set<String> overwriteByPartitionKeys,
+ Set<String> primaryKeys) {
Review Comment:
To be clear, you're just suggesting changing the variable name from
`primaryKeys` to `primaryKey`, right? And leaving its data type intact of
`Set<String>`, since a Primary Key can consist of two fields - the Partition
Key and the Sort Key?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
