davidradl commented on code in PR #25660:
URL: https://github.com/apache/flink/pull/25660#discussion_r1853927260
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/sink/CommitterOperator.java:
##########
@@ -181,7 +181,7 @@ private void commitAndEmitCheckpoints() throws IOException,
InterruptedException
private void commitAndEmit(CheckpointCommittableManager<CommT>
committableManager)
throws IOException, InterruptedException {
Collection<CommittableWithLineage<CommT>> committed =
committableManager.commit(committer);
Review Comment:
NIT: as we are no longer using committed in the if, we could move
`committableManager.commit(committer)` inlined to line 189 and remove the
`committed` variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
